Recurring invoice status

[carlos]

There are three possible status values: draft, enabled, disabled This can be accomplished with two boolean fields: draft and enabled. If draft is true then enabled should be false (IMHO)

[jzarate]

Replying to carlos:

There are three possible status values: draft, enabled, disabled This can be accomplished with two boolean fields: draft and enabled. If draft is true then enabled should be false (IMHO)

I was thinking the same. Just one thing: do we need the app to be aware of not letting "enabled" and "draft" being activated at the same time?? Doing that would imply:

• overwritting the "setDraft" and "setEnabled" methods to disable their counterpart on activation.
• use javascript to make the draft / enabled checkboxes act in a similar way at the forms (the draft checkbox automatically unchecked when checking enabled checkbox and viceversa).

Or we could just set a priority list and let the system choose .

[carlos]

Replying to jzarate:

Replying to carlos:

There are three possible status values: draft, enabled, disabled This can be accomplished with two boolean fields: draft and enabled. If draft is true then enabled should be false (IMHO)

I was thinking the same. Just one thing: do we need the app to be aware of not letting "enabled" and "draft" being activated at the same time?? Doing that would imply: - overwritting the "setDraft" and "setEnabled" methods to disable their counterpart on activation. - use javascript to make the draft / enabled checkboxes act in a similar way at the forms (the draft checkbox automatically unchecked when checking enabled checkbox and viceversa). Or we could just set a priority list and let the system choose .

Well, if we simplify a bit more, we could remove the draft status and use only enabled/disabled, letting the latter be the 'draft' status by default.

[jzarate]

Replying to carlos:

Replying to jzarate:

Replying to carlos:

There are three possible status values: draft, enabled, disabled This can be accomplished with two boolean fields: draft and enabled. If draft is true then enabled should be false (IMHO)

I was thinking the same. Just one thing: do we need the app to be aware of not letting "enabled" and "draft" being activated at the same time?? Doing that would imply: - overwritting the "setDraft" and "setEnabled" methods to disable their counterpart on activation. - use javascript to make the draft / enabled checkboxes act in a similar way at the forms (the draft checkbox automatically unchecked when checking enabled checkbox and viceversa). Or we could just set a priority list and let the system choose .

Well, if we simplify a bit more, we could remove the draft status and use only enabled/disabled, letting the latter be the 'draft' status by default.

I don't think we need to reach that level of simplicity. In final words, draft is one thing (meaning the recurring invoice is being made and not ready) and enabled, disabled a completely different one, although, for filtering purposes, we could use them as three kinds of "status".

Why don't we just treat them as what they are? enabled/disabled is not related to draft. If an invoice is in draft, no matter you have "enabled" or "disabled" it. It will not be active since it's draft (in fact, the "enable/disable" check is just like any other property of the recurring that you may be editing while it's in draft status).

[jzarate]

I'm going to close this ticket, and do as I've said with the draft, enabled and disabled checkboxes.